linux-kernel - Re: [PATCH -next] platform/chrome: Make function wilco_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Feb 2019 11:14:07 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Benson Leung <bleung@...omium.org>,
        Duncan Laurie <dlaurie@...gle.com>,
        Nick Crews <ncrews@...omium.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] platform/chrome: Make function wilco_ec_transfer()
 static



On 16/2/19 7:09, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning:
>  symbol 'wilco_ec_transfer' was not declared. Should it be static?
> 
> Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/platform/chrome/wilco_ec/mailbox.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Applied for 5.1

Thanks

> diff --git a/drivers/platform/chrome/wilco_ec/mailbox.c b/drivers/platform/chrome/wilco_ec/mailbox.c
> index c7028488e575..f6ff29a11f1a 100644
> --- a/drivers/platform/chrome/wilco_ec/mailbox.c
> +++ b/drivers/platform/chrome/wilco_ec/mailbox.c
> @@ -123,8 +123,9 @@ static void wilco_ec_prepare(struct wilco_ec_message *msg,
>   * Context: ec->mailbox_lock should be held while using this function.
>   * Return: number of bytes received or negative error code on failure.
>   */
> -int wilco_ec_transfer(struct wilco_ec_device *ec, struct wilco_ec_message *msg,
> -		      struct wilco_ec_request *rq)
> +static int wilco_ec_transfer(struct wilco_ec_device *ec,
> +			     struct wilco_ec_message *msg,
> +			     struct wilco_ec_request *rq)
>  {
>  	struct wilco_ec_response *rs;
>  	u8 checksum;
> 
> 
>