lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Feb 2019 11:15:56 +0100
From:   Krzysztof Kozlowski <>
To:     Russell King <>,
        Mark Brown <>,,,
        Greg Kroah-Hartman <>,
        "Rafael J. Wysocki" <>,
        Sylwester Nawrocki <>,
        Tomasz Figa <>,
        Chanwoo Choi <>,
        Michael Turquette <>,
        Stephen Boyd <>, Kukjin Kim <>,
        Krzysztof Kozlowski <>,
        Andy Gross <>,
        David Brown <>,
        Srinivas Kandagatla <>,,,,,
Subject: [RFC 0/4] clk/driver: platform: Fix kfree() of const memory on setting driver_override


The problem
Several device types (platform, amba, spi etc.) provide a driver_override
field.  On sysfs store or during device removal, they kfree() the
existing value.

However the users are unaware of this and set the driver_override like:

 	pdev->driver_override = "exynos5-subcmu";

which obviously leads to error.

I provided simple helper for platform device.  If this approach is
acceptable, I can convert also other buses, like AMBA, SPI.

Dependencies and pick up order
Patch 1: please pick it as is through clock tree
Patch 3: Depends on patch 1 (merge conflict) and 2.
Patch 4: Depends on patch 2.

Best regards,

Krzysztof Kozlowski (4):
  clk: samsung: exynos5: Fix possible NULL pointer exception on
    platform_device_alloc() failure
  driver: platform: Provide helper for safer setting of driver_override
  clk: samsung: exynos5: Fix kfree() of const memory on setting
  slimbus: ngd: Fix kfree() of const memory on setting driver_override

 drivers/base/platform.c                  | 63 ++++++++++++++++++++++----------
 drivers/clk/samsung/clk-exynos5-subcmu.c | 12 ++++--
 drivers/slimbus/qcom-ngd-ctrl.c          |  2 +-
 include/linux/platform_device.h          |  9 ++++-
 4 files changed, 61 insertions(+), 25 deletions(-)


Powered by blists - more mailing lists