linux-kernel - Re: [PATCH] platform: set of_node in platform_device_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xk1hxxss8.fsf@mansr.com>
Date:   Mon, 18 Feb 2019 11:03:35 +0000
From:   Måns Rullgård <mans@...sr.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform: set of_node in platform_device_register_full()

"Rafael J. Wysocki" <rafael@...nel.org> writes:

> On Sat, Feb 16, 2019 at 5:50 PM Mans Rullgard <mans@...sr.com> wrote:
>>
>> If the provided fwnode is an OF node, set dev.of_node as well.
>>
>> Signed-off-by: Mans Rullgard <mans@...sr.com>
>> ---
>>  drivers/base/platform.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
>> index dff82a3c2caa..853a1d0e5845 100644
>> --- a/drivers/base/platform.c
>> +++ b/drivers/base/platform.c
>> @@ -512,6 +512,7 @@ struct platform_device *platform_device_register_full(
>>
>>         pdev->dev.parent = pdevinfo->parent;
>>         pdev->dev.fwnode = pdevinfo->fwnode;
>> +       pdev->dev.of_node = of_node_get(to_of_node(pdev->dev.fwnode));
>
> of_node_get() generally does a kobject_get() on the node's kobject, so
> when is that reference dropped?  Or if it doesn't need to be dropped
> at all, why is this the case?

platform_device_release() calls of_device_node_put().

-- 
Måns Rullgård