linux-kernel - Re: [PATCH] perf report: Don't shadow inlined symbol with different addr range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219152959.GC31177@kernel.org>
Date:   Tue, 19 Feb 2019 12:29:59 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     He Kuang <hekuang@...wei.com>
Cc:     Milian Wolff <milian.wolff@...b.com>, Jiri Olsa <jolsa@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf report: Don't shadow inlined symbol with different
 addr range

Em Tue, Feb 19, 2019 at 03:02:13PM +0100, Jiri Olsa escreveu:
> On Tue, Feb 19, 2019 at 09:05:31PM +0800, He Kuang wrote:
> > We can't assume inlined symbols with the same name are equal, because
> > their address range may be different. This will cause the symbols with
> > different addresses be shadowed when adding to the hist entry, and lead
> > to ERANGE error when checking the symbol address during sample parse, the
> > addr should be within the range of [sym.start, sym.end].

> > The error message is like: "0x36aea60 [0x8]: failed to process type: 68".

> > The second parameter of symbol__new() is the length of the fake symbol for
> > the inline frame, which is the subtraction of the end and start address of
> > base_sym.

> > Signed-off-by: He Kuang <hekuang@...wei.com>

> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks, applying and adding the missing Fixes line:

Fixes: aa441895f7b4 ("perf report: Compare symbol name for inlined frames when sorting")

Also added Millian, the author of that patch to the Cc list, so that he
can check this as well if he has the time for doing so.

Please double check that this indeed is when this problem was
introduced,

- Arnaldo