linux-kernel - Re: [PATCH -next] tpm: change the return type of calc_tpm2_event_size to size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190219163456.GB752@ziepe.ca>
Date:   Tue, 19 Feb 2019 09:34:56 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     YueHaibing <yuehaibing@...wei.com>, peterhuewe@....de,
        arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org
Subject: Re: [PATCH -next] tpm: change the return type of
 calc_tpm2_event_size to size_t

On Tue, Feb 19, 2019 at 12:35:32PM +0200, Jarkko Sakkinen wrote:
> On Tue, Feb 19, 2019 at 05:15:47PM +0800, YueHaibing wrote:
> > On 2019/2/19 16:59, Jarkko Sakkinen wrote:
> > > On Tue, Feb 19, 2019 at 03:26:18PM +0800, YueHaibing wrote:
> > >> calc_tpm2_event_size return size of the event which type is
> > >> size_t, If it is an invalid event, returns 0. And all the
> > >> caller use a size_t variable to check the return value, so
> > >> no need to convert to the return value type to int.
> > >>
> > >> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > > 
> > > I don't see this patch make any value.
> > 
> > calc_tpm2_event_size return size_t 'size' which derive from u32 'event_field->event_size',
> > 
> > convert it to int may result in truncation.
> 
> Two remarks:
> 
> - Your real name is formatted incorrectly. It should be like "Yue Haibig"
>   as shown in [1].
> - If there is no actual regression, this change is useless.

Clarity of the code is a laudible goal - not everything is about
fixing bugs or adding features.

It is much easier to write the code properly than to try and prove
that event_size can not exceed INT_MAX.

Jason