linux-kernel - Re: [PATCH -next] tpm: change the return type of calc_tpm2_event_size to size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Feb 2019 19:31:20 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     YueHaibing <yuehaibing@...wei.com>, peterhuewe@....de,
        arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org
Subject: Re: [PATCH -next] tpm: change the return type of
 calc_tpm2_event_size to size_t

On Tue, Feb 19, 2019 at 09:34:56AM -0700, Jason Gunthorpe wrote:
> > - Your real name is formatted incorrectly. It should be like "Yue Haibig"
> >   as shown in [1].
> > - If there is no actual regression, this change is useless.
> 
> Clarity of the code is a laudible goal - not everything is about
> fixing bugs or adding features.
> 
> It is much easier to write the code properly than to try and prove
> that event_size can not exceed INT_MAX.

I think it is actually a regression in 4d23cc323cdb.  Should carry a
fixes tag. I did not quite undersand what commit message was saying.
What it should would just

"""
tpm: Fix the type of the return value in calc_tpm2_event_size()

calc_tpm2_event_size() has an invalid signature because it returns a 'size_t'
where as its signature says that it returns 'int'.
"""

Should be also Cc'd to linux-security-module and have cc to stable.

/Jarkko