linux-kernel - Re: [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abf49724-6567-43cf-852c-027c7948860d@ti.com>
Date:   Tue, 19 Feb 2019 11:05:24 -0600
From:   "Andrew F. Davis" <afd@...com>
To:     <Codrin.Ciubotariu@...rochip.com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>
CC:     <dannenberg@...com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of
 DECLARE_TLV_DB_SCALE()

On 2/19/19 10:29 AM, Codrin.Ciubotariu@...rochip.com wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> 
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
> 
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> ---

Acked-by: Andrew F. Davis <afd@...com>

> 
> Changes in v2:
>  - fixed title - added correct macro;
>  - revert the removal of a new line;
> 
>  sound/soc/codecs/pcm186x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..c36a391fec8a 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -42,7 +42,7 @@ struct pcm186x_priv {
>  	bool is_master_mode;
>  };
>  
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>  
>  static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
>  	SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
>