linux-kernel - Re: linux-next: Fixes tag needs some work in the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190220213729.49deb54f@redhat.com>
Date:   Wed, 20 Feb 2019 21:37:29 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     jiri@...nulli.us, vkoul@...nel.org, sfr@...b.auug.org.au,
        netdev@...r.kernel.org, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrew@...n.ch
Subject: Re: linux-next: Fixes tag needs some work in the net-next tree

On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Stefano Brivio <sbrivio@...hat.com>
> Date: Wed, 20 Feb 2019 20:59:10 +0100
> 
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller <davem@...emloft.net> wrote:
> >   
> >> From: Jiri Pirko <jiri@...nulli.us>
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>   
> >> > Would be good to have some robot checking "Fixes" sanity...    
> >> 
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that....  
> > 
> > If it helps, this is what I use after being bitten once:  
> 
> Awesome, thanks!  You put this in as a pre-commit script?

Nope, I use it before sending patches out with git send-email.

But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):

#!/bin/sh

grep "^Fixes: " "${1}" | while read -r f; do
	sha="$(echo "${f}" | cut -d' ' -f2)"
	if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
		echo "Bad tag: ${f}" && exit 1
	fi
done

-- 
Stefano