linux-kernel - Re: [PATCH] KEYS: user: Align the payload buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1902210750180.1411@namei.org>
Date:   Thu, 21 Feb 2019 07:50:31 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     David Howells <dhowells@...hat.com>
cc:     David Laight <David.Laight@...LAB.COM>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Eric Biggers <ebiggers@...gle.com>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KEYS: user: Align the payload buffer

On Wed, 20 Feb 2019, David Howells wrote:

> David Laight <David.Laight@...LAB.COM> wrote:
> 
> > I'd make the 'datalen' field 'unsigned int' at the same time.
> > It will use some of the hole you've made and generate better
> > code on most arches.
> 
> Most arches?  I though most, if not all, arches had a load-word instruction.
> 
> Do you want to send me a patch for that?  I'd rather not alter this patch at
> this point.  I can pass the additional patch to James for the next merge
> window.

Should this first one go into -rc?


-- 
James Morris
<jmorris@...ei.org>