linux-kernel - Re: [PATCH] KEYS: user: Align the payload buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16012.1550671795@warthog.procyon.org.uk>
Date:   Wed, 20 Feb 2019 14:09:55 +0000
From:   David Howells <dhowells@...hat.com>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     dhowells@...hat.com, "jmorris@...ei.org" <jmorris@...ei.org>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Eric Biggers <ebiggers@...gle.com>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KEYS: user: Align the payload buffer

David Laight <David.Laight@...LAB.COM> wrote:

> I'd make the 'datalen' field 'unsigned int' at the same time.
> It will use some of the hole you've made and generate better
> code on most arches.

Most arches?  I though most, if not all, arches had a load-word instruction.

Do you want to send me a patch for that?  I'd rather not alter this patch at
this point.  I can pass the additional patch to James for the next merge
window.

David