lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 20 Feb 2019 10:45:45 +0100
From:   Linus Walleij <>
To:     "Enrico Weigelt, metux IT consult" <>
Cc:     "" <>,
        "open list:GPIO SUBSYSTEM" <>,
        Bartosz Golaszewski <>,
        Andy Shevchenko <>,
        platform-driver-x86 <>
Subject: Re: [PATCH v3 1/2] gpio: AMD G-Series PCH gpio driver

On Thu, Feb 14, 2019 at 11:05 PM Enrico Weigelt, metux IT consult
<> wrote:

> GPIO platform driver for the AMD G-series PCH (eg. on GX-412TC)
> This driver doesn't registers itself automatically, as it needs to
> be provided with platform specific configuration, provided by some
> board driver setup code.
> Didn't implement oftree probing yet, as it's rarely found on x86.
> Cc:
> Cc:
> Cc:
> Cc:
> Cc:
> Cc:
> Signed-off-by: Enrico Weigelt, metux IT consult <>

> +config GPIO_AMD_FCH
> +       tristate "GPIO support for AMD Fusion Controller Hub (G-series SOCs)"
> +       select GPIO_GENERIC

Now I see that you do this

> +       spin_lock_irqsave(&priv->gc.bgpio_lock, flags);
> +       spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags);

Only to get that spinlock.

That's not what GPIO_GENERIC is for, just put a spinlock in your
local state container struct amd_fch_gpio_priv instead.

Linus Walleij

Powered by blists - more mailing lists