lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Feb 2019 10:58:29 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: "Enrico Weigelt, metux IT consult" <info@...ux.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, Andy Shevchenko <andy@...radead.org>, Platform Driver <platform-driver-x86@...r.kernel.org> Subject: Re: APUv2/v3 board support V3 On Fri, Feb 15, 2019 at 7:16 PM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult > Linus, this one looks good enough, though some style minors can be addressed: > - redundant parens (and actually I prefer to see x = readl(); x |= > ...; writel(); in three lines) > - useless blank lines > - style of parameters where one per line (it's not needed in this drivers) > > In any case, FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> OK Enrico can you include Andy's Review tag when you respin, fix the spinlock issue I pointed out and send out as v4 and I'll apply it. Yours, Linus Walleij
Powered by blists - more mailing lists