linux-kernel - Re: [PATCH v2 1/2] scsi: replace GFP_ATOMIC with GFP_KERNEL for allocations in scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1550774719.31902.137.camel@acm.org>
Date:   Thu, 21 Feb 2019 10:45:19 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Benjamin Block <bblock@...ux.ibm.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Cc:     Steffen Maier <maier@...ux.ibm.com>, linux-scsi@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: replace GFP_ATOMIC with GFP_KERNEL for
 allocations in scsi_scan.c

On Thu, 2019-02-21 at 10:18 +0100, Benjamin Block wrote:
> Looking at the code of scsi_alloc_sdev(), and all the calling contexts,
> there seems to be no reason to use GFP_ATMOIC here. All the different
> call-contexts use a mutex at some point, and nothing in between that
> requires no sleeping, as far as I could see. Additionally, the code that
> later allocates the block queue for the device (scsi_mq_alloc_queue())
> already uses GFP_KERNEL.
> 
> 
> [ ... ]
>
> So replace all these, and give them a bit of a better chance to succeed,
> with more chances of reclaim.

Reviewed-by: Bart Van Assche <bvanassche@....org>