linux-kernel - Re: [PATCH v1 0/2] PCI/ASPM: Fix LTR issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222045824.GD219879@google.com>
Date:   Thu, 21 Feb 2019 22:58:24 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     linux-pci@...r.kernel.org
Cc:     RussianNeuroMancer <russianneuromancer@...ru>,
        David Ward <david.ward@...mit.edu>,
        Frederick Lawler <fred@...dlawl.com>,
        Patrick Talbert <ptalbert@...hat.com>,
        Lukas Wunner <lukas@...ner.de>,
        Srinath Mannam <srinath.mannam@...adcom.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/2] PCI/ASPM: Fix LTR issues

On Mon, Feb 11, 2019 at 04:55:33PM -0600, Bjorn Helgaas wrote:
> These are to fix a couple LTR-related issues found while investigating
> https://bugzilla.kernel.org/show_bug.cgi?id=201469
> 
> I don't claim that these fix the whole problem of that bugzilla, but I
> think it's pretty clear that these are problems we need to fix, so I want
> to give these a little more exposure.
> 
> Feedback welcome!
> 
> ---
> 
> Bjorn Helgaas (2):
>       PCI/ASPM: Use LTR if already enabled by platform
>       PCI/ASPM: Save LTR Capability for suspend/resume
> 
> 
>  drivers/pci/pci.c   |   53 +++++++++++++++++++++++++++++++++++++++++++++++++--
>  drivers/pci/probe.c |   36 ++++++++++++++++++++++-------------
>  2 files changed, 74 insertions(+), 15 deletions(-)

I applied these to pci/aspm for v5.1.

I think Vidya is absolutely right that we also need to save/restore
the ASPM L1 Substates capability.  But I haven't had a chance to
write that up yet, and I think these two patches by themselves
are an improvement even without ASPM L1 SS.

Bjorn