linux-kernel - Re: [PATCH v1 0/2] PCI/ASPM: Fix LTR issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4865264.tNTiON9z6m@aspire.rjw.lan>
Date:   Fri, 22 Feb 2019 10:37:34 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org,
        RussianNeuroMancer <russianneuromancer@...ru>,
        David Ward <david.ward@...mit.edu>,
        Frederick Lawler <fred@...dlawl.com>,
        Patrick Talbert <ptalbert@...hat.com>,
        Lukas Wunner <lukas@...ner.de>,
        Srinath Mannam <srinath.mannam@...adcom.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/2] PCI/ASPM: Fix LTR issues

On Friday, February 22, 2019 5:58:24 AM CET Bjorn Helgaas wrote:
> On Mon, Feb 11, 2019 at 04:55:33PM -0600, Bjorn Helgaas wrote:
> > These are to fix a couple LTR-related issues found while investigating
> > https://bugzilla.kernel.org/show_bug.cgi?id=201469
> > 
> > I don't claim that these fix the whole problem of that bugzilla, but I
> > think it's pretty clear that these are problems we need to fix, so I want
> > to give these a little more exposure.
> > 
> > Feedback welcome!
> > 
> > ---
> > 
> > Bjorn Helgaas (2):
> >       PCI/ASPM: Use LTR if already enabled by platform
> >       PCI/ASPM: Save LTR Capability for suspend/resume
> > 
> > 
> >  drivers/pci/pci.c   |   53 +++++++++++++++++++++++++++++++++++++++++++++++++--
> >  drivers/pci/probe.c |   36 ++++++++++++++++++++++-------------
> >  2 files changed, 74 insertions(+), 15 deletions(-)
> 
> I applied these to pci/aspm for v5.1.
> 
> I think Vidya is absolutely right that we also need to save/restore
> the ASPM L1 Substates capability.  But I haven't had a chance to
> write that up yet, and I think these two patches by themselves
> are an improvement even without ASPM L1 SS.

Agreed.

Cheers,
Rafael