linux-kernel - Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <155082210099.77512.4042430864962937771@swboyd.mtv.corp.google.com>
Date:   Thu, 21 Feb 2019 23:55:00 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     mtk14994 <wangyan.wang@...iatek.com>
Cc:     CK Hu <ck.hu@...iatek.com>,
        Michael Turquette <mturquette@...libre.com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        srv_heupstream@...iatek.com,
        chunhui dai <chunhui.dai@...iatek.com>,
        David Airlie <airlied@...ux.ie>,
        Sean Wang <sean.wang@...iatek.com>,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

Quoting mtk14994 (2019-02-20 18:34:11)
> Dear Stephen,
> > +       unsigned char mux_flags;
> > 
> > Why isn't it an unsigned long? Isn't this supposed to match the
> > frameworks version of the clk flags?
> 
> ---->   it is unsigned char mux_flags ,becasuse struct clk_mux {
> 
> ....
> ....
> u8 flags;
> ....
> }
> 
> it is matched when use " mux->flags = mc->mux_flags;"
> 

Please try to not top-post.

Ok I thought it was the generic clk flags, not the mux specific flag
bits. Sounds fine then, but I would sort of expect it to match the type
in clk_mux then, i.e. be a u8 instead of an unsigned char (yes it's the
same in the end but it looks different at a glance).