linux-kernel - Re: [PATCH v3 0/3] gcov: add Clang support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Feb 2019 16:57:03 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Peter Oberparleiter <oberpar@...ux.ibm.com>
Cc:     Greg Hackmann <ghackmann@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@...roid.com,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Tri Vo <trong@...roid.com>, Mark Brown <mark.brown@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v3 0/3] gcov: add Clang support

On Wed, Feb 6, 2019 at 4:52 PM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>
> On Tue, Jan 22, 2019 at 3:38 PM Tri Vo <trong@...roid.com> wrote:
> >
> > This patch series adds Clang supoprt for gcov.
> >
> > Patch 1 refactors existing code in preparation for Clang support.
> > Patch 2 implements necessary LLVM runtime hooks and gcov kernel interfaces.
> > Patch 3 updates documentation.
> >
> > Greg Hackmann (2):
> >   gcov: Clang: move common GCC code into gcc_base.c
> >   gcov: Clang support
> >
> > Tri Vo (1):
> >   gcov: docs: add a note on GCC vs Clang differences
> >
> >  Documentation/dev-tools/gcov.rst |  18 +-
> >  kernel/gcov/Kconfig              |   3 +-
> >  kernel/gcov/Makefile             |   5 +-
> >  kernel/gcov/base.c               |  84 +----
> >  kernel/gcov/clang.c              | 555 +++++++++++++++++++++++++++++++
> >  kernel/gcov/gcc_base.c           |  86 +++++
> >  kernel/gcov/gcov.h               |   3 +
> >  7 files changed, 665 insertions(+), 89 deletions(-)
> >  create mode 100644 kernel/gcov/clang.c
> >  create mode 100644 kernel/gcov/gcc_base.c
> >
> > v2:
> > - Reorganized config dependencies, as per Masahiro.
> >
> > v3:
> > - Squashed patches 2-4 of v2, as per Nick, Masahiro, and Peter.
> > Addressed comments by Peter:
> > - Moved __gcov_exit() to gcc_base.c
> > - Added missing header to gcc_base.c
> > - Removed unnecessary boundary checks in gcov_info_add().
> > - Changed counters' allocation to use vmalloc().
> > - Added check for failed allocation of filename.
> > - Changed list_for_each_entry_safe to list_for_each_entry when traversing
> >   without modifying.
> > - Updated Documentation/dev-tools/gcov.rst
> >
> > --
> > 2.20.1.321.g9e740568ce-goog
> >
>
> Bumping this thread for review.
>
> --
> Thanks,
> ~Nick Desaulniers

Bumping for review; KernelCI is ready to enable clang builds.  This is
the final build error for arm64 allyesconfig + clang.

-- 
Thanks,
~Nick Desaulniers