linux-kernel - Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Feb 2019 19:57:54 -0500
From:   YU Bo <tsu.yubo@...il.com>
To:     Gao Xiang <gaoxiang25@...wei.com>
Cc:     yuchao0@...wei.com, gregkh@...uxfoundation.org, yuzibode@....com,
        linux-erofs@...ts.ozlabs.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Miao Xie <miaoxie@...wei.com>,
        "fangwei (I)" <fangwei1@...wei.com>
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared
 symbols in erofs

Hi,
On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>Hi Bo,
>
>On 2019/2/21 22:28, Bo YU wrote:
>> From: Bo Yu <tsu.yubo@...il.com>
>>
>> Fix sparse warnings:
>>
>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>
>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>> Cc: Gao Xiang <gaoxiang25@...wei.com>
>> Cc: Chao Yu <yuchao0@...wei.com>
>> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Bo Yu <tsu.yubo@...il.com>
>> ---
>>  drivers/staging/erofs/utils.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>> index b535898ca753..33cd5ad55cb8 100644
>> --- a/drivers/staging/erofs/utils.c
>> +++ b/drivers/staging/erofs/utils.c
>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>>  	__erofs_workgroup_free(grp);
>>  }
>>
>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>  				    struct erofs_workgroup *grp,
>>  				    bool cleanup)
>>  {
>>
>
>Have you looked the latest kernel code?
Emm...yeah.But i pulled linus tree not staging tree :(
Sorry for the noise.

>It seems erofs_try_to_release_workgroup is already be claimed as static...
>
>See:
>https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>
>Thanks,
>Gao Xiang
>