linux-kernel - Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c238a08cfaae0bd09e434edc889b0ecab50aee24.camel@perches.com>
Date:   Thu, 21 Feb 2019 17:20:19 -0800
From:   Joe Perches <joe@...ches.com>
To:     Alex_Gagniuc@...lteam.com, lukas@...ner.de, mr.nuke.me@...il.com
Cc:     bhelgaas@...gle.com, Austin.Bolen@...l.com, keith.busch@...el.com,
        Shyam.Iyer@...l.com, okaya@...nel.org, linux-pci@...r.kernel.org,
        mika.westerberg@...ux.intel.com, okaya@...eaurora.org,
        poza@...eaurora.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie
 switches

On Thu, 2019-02-21 at 18:35 +0000, Alex_Gagniuc@...lteam.com wrote:
> On 2/21/19 1:57 AM, Lukas Wunner wrote:
> > On Tue, Feb 19, 2019 at 07:20:30PM -0600, Alexandru Gagniuc wrote:
> > > --- a/drivers/pci/hotplug/pciehp_hpc.c
> > > 
> > > +}
> > > +
> > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_PLX, 0x9733,
> > 
> > By convention there's no blank line between the closing curly brace
> > and the DECLARE_PCI_FIXUP_CLASS_FINAL().

Not completely true.
See: arch/mips/pci/fixup-loongson3.c

> I'm sorry for all the style issues. I realize it's noise and should just 
> be done right from the beginning. Is there a way to make checkpatch.pl 
> catch these before they go out?

You could write a new rule, but it's non trivial as
there are multiple consecutive uses and multi-line
uses too.

I think it's a rule not worth writing.