linux-kernel - Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190222235915.bdf82008eef24f8189bd33ec@kernel.org>
Date:   Fri, 22 Feb 2019 23:59:15 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mingo@...hat.com, Juerg Haefliger <juergh@...onical.com>
Subject: Re: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033

On Fri, 22 Feb 2019 10:10:21 +0100
Juerg Haefliger <juerg.haefliger@...onical.com> wrote:

> The \e sequence character is not POSIX. Fix that by using \033 instead.
> 
> Signed-off-by: Juerg Haefliger <juergh@...onical.com>

This also looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> ---
>  tools/testing/selftests/ftrace/ftracetest | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
>  color_blue=
>  # If stdout exists and number of colors is eight or more, use them
>  if [ -t 1 -a "$ncolors" -ge 8 ]; then
> -  color_reset="\e[0m"
> -  color_red="\e[31m"
> -  color_green="\e[32m"
> -  color_blue="\e[34m"
> +  color_reset="\033[0m"
> +  color_red="\033[31m"
> +  color_green="\033[32m"
> +  color_blue="\033[34m"
>  fi
>  
>  strip_esc() {
> -- 
> 2.19.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>