linux-kernel - Re: [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a9d8ad8-8520-a0f7-9c55-94740a3a1248@kernel.org>
Date:   Fri, 22 Feb 2019 08:58:58 -0700
From:   shuah <shuah@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Juerg Haefliger <juerg.haefliger@...onical.com>
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mingo@...hat.com, Juerg Haefliger <juergh@...onical.com>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH v2 1/2] selftests/ftrace: Replace echo -e with printf

Hi Juerg,

On 2/22/19 7:58 AM, Masami Hiramatsu wrote:
> On Fri, 22 Feb 2019 10:10:20 +0100
> Juerg Haefliger <juerg.haefliger@...onical.com> wrote:
> 
>> echo -e is not POSIX. Depending on what /bin/sh is, we can get
>> incorrect output like:
>> $ -e -n [1] Basic trace file check
>> $ -e 	[PASS]
>>
>> Fix that by using printf instead.
>>
>> Signed-off-by: Juerg Haefliger <juergh@...onical.com>
> 
> Looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> 

I wasn't on the To or Cc on the original patch. Make sure to
run the get_maintainers and include the people it recommends.

Please resend the patch to me, so I can take it for 5.1-rc1

thanks,
-- Shuah