linux-kernel - Re: [PATCH] docs: Explicitly state that the 'Fixes:' tag shouldn't split lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190222085637.39f02baa@lwn.net>
Date:   Fri, 22 Feb 2019 08:56:37 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] docs: Explicitly state that the 'Fixes:' tag shouldn't
 split lines

On Tue, 19 Feb 2019 07:27:15 -0800
Sean Christopherson <sean.j.christopherson@...el.com> wrote:

> ...and use a commit with an obnoxiously long summary in the example to
> make it abundantly clear that keeping the tag on a single line takes
> priority over wrapping at 75 columns.  Without the explicit exemption,
> one might assume splitting the tag is acceptable, even encouraged, e.g.
> due to being conditioned by checkpatch's line length warning.
> 
> Per Stephen's scripts[1] and implied by commit bf4daf12a9fb ("checkpatch:
> avoid some commit message long line warnings"), splitting the 'Fixes:'
> tag across multiple lines is a no-no, presumably because parsing multi-
> line tags is unnecessarily painful.
> 
> [1] https://lkml.kernel.org/r/20190216183433.71b7cfa7@canb.auug.org.au
> 
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>

Applied, thanks.

jon