linux-kernel - Re: [PATCH v3] PM / suspend: measure the time of filesystem syncing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9647a9f3c84cfc055603ecf0b693250d343dd6c6.camel@intel.com>
Date:   Fri, 22 Feb 2019 15:56:38 +0000
From:   "Pan, Harry" <harry.pan@...el.com>
To:     "rafael@...nel.org" <rafael@...nel.org>
CC:     "Brown, Len" <len.brown@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gs0622@...il.com" <gs0622@...il.com>,
        "pavel@....cz" <pavel@....cz>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
Subject: Re: [PATCH v3] PM / suspend: measure the time of filesystem syncing

> Why don't you add a "sync" helper function in main.c with the timing
> and message that will be called from hibernate.c, user.c and
> suspend.c
> (in the last one conditional on
> !IS_ENABLED(CONFIG_SUSPEND_SKIP_SYNC))?
> 
> That would reduce some code duplication nicely.

I uploaded v5 in reciprocate to your comment, I apologize I sent it
second time in order to clean up the header files.

-Harry