linux-kernel - Re: [PATCH 15/15] perf script python: add Python3 support to sql scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6ebfebb-0dbf-33d0-688c-cdcce6f0ce81@suse.de>
Date:   Mon, 25 Feb 2019 09:20:15 -0800
From:   Tony Jones <tonyj@...e.de>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>
Subject: Re: [PATCH 15/15] perf script python: add Python3 support to sql
 scripts

On 2/25/19 6:54 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 25, 2019 at 11:51:19AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Feb 22, 2019 at 03:06:19PM -0800, Tony Jones escreveu:
>>> Support both Python2 and Python3 in the exported-sql-viewer.py,
>>> export-to-postgresql.py and export-to-sqlite.py scripts
> <SNIP>
>>> @@ -234,12 +236,17 @@ perf_db_export_mode = True
>>>  perf_db_export_calls = False
>>>  perf_db_export_callchains = False
>>>  
>>> +def printerr(*args, **kw_args):
>>> +    print(*args, file=sys.stderr, **kw_args)
>>> +
>>> +def printdate(*args, **kw_args):
>>> +        print(datetime.datetime.today(), *args, sep=' ', **kw_args)
>>
>> So this one introduces inconsistencies in indentation, i.e. the above
>> two routines don't use tabs and one uses 4 spaces while the other uses 8
>> spaces :-\
>>
>> I'm converting them to use tabs, like the rest of this script, ok?
> 
> But it is not applying, Adrian did work recently here, can you please
> address this and resubmit?

I was using perf/perf/core.   I'll take a look.

Also, I agree we should be consistent on indentation.