linux-kernel - Re: [PATCH 02/15] perf script python: add Python3 support to check-perf-trace.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82af3618-8d99-7985-aa3c-3bdc6231d4cf@suse.de>
Date:   Mon, 25 Feb 2019 10:05:47 -0800
From:   Tony Jones <tonyj@...e.de>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Seeteena Thoufeek <s1seetee@...ux.vnet.ibm.com>,
        Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 02/15] perf script python: add Python3 support to
 check-perf-trace.py

On 2/25/19 6:05 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 22, 2019 at 03:06:06PM -0800, Tony Jones escreveu:
>> Support both Python 2 and Python 3 in the check-perf-trace.py script.
>>
>> There may be differences in the ordering of output lines due to
>> differences in dictionary ordering etc.  However the format within lines
>> should be unchanged.
>>
>> Also correct inconsistent indentation which was being flagged by Python3.
> 
> When we have "Also" in a patch, usually it need to be split :-)

The indentation changes were required for Python3. So I viewed them as part of the change
to support Python3 ;-)  However, splitting them is no problem.    I'll resubmit.