linux-kernel - Re: [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf12b_mR7yCgv7j9s87dLsDLD4cshLj84mdHJH-TNRQPu4w@mail.gmail.com>
Date:   Tue, 26 Feb 2019 22:59:11 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors

On Tue, Feb 26, 2019 at 6:42 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Several places in the habanalabs driver use gen_alloc functions,
> so select GENERIC_ALLOCATOR to make those functions available.
>
> Fixes these build errors:
>
> ERROR: "gen_pool_alloc" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_add_virt" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_destroy" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_create" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_free" [drivers/misc/habanalabs/habanalabs.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Oded Gabbay <oded.gabbay@...il.com>
> ---
>  drivers/misc/habanalabs/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20190226.orig/drivers/misc/habanalabs/Kconfig
> +++ linux-next-20190226/drivers/misc/habanalabs/Kconfig
> @@ -6,6 +6,7 @@ config HABANA_AI
>         tristate "HabanaAI accelerators (habanalabs)"
>         depends on PCI
>         select FRAME_VECTOR
> +       select GENERIC_ALLOCATOR
>         help
>           Enables PCIe card driver for Habana's AI Processors (AIP) that are
>           designed to accelerate Deep Learning inference and training workloads.
>
>

Thanks for catching that.
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>