lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 27 Feb 2019 09:38:48 -0800
From:   Dave Hansen <>
To:     Steven Price <>,
Cc:     Andy Lutomirski <>,
        Ard Biesheuvel <>,
        Arnd Bergmann <>, Borislav Petkov <>,
        Catalin Marinas <>,
        Dave Hansen <>,
        Ingo Molnar <>,
        James Morse <>,
        Jérôme Glisse <>,
        Peter Zijlstra <>,
        Thomas Gleixner <>,
        Will Deacon <>,,
        "H. Peter Anvin" <>,,,
        Mark Rutland <>,
        "Liang, Kan" <>
Subject: Re: [PATCH v3 27/34] mm: pagewalk: Add 'depth' parameter to pte_hole

On 2/27/19 9:06 AM, Steven Price wrote:
>  #ifdef CONFIG_SHMEM
>  static int smaps_pte_hole(unsigned long addr, unsigned long end,
> -		struct mm_walk *walk)
> +			  __always_unused int depth, struct mm_walk *walk)
>  {

I think this 'depth' argument is a mistake.  It's synthetic and it's
surely going to be a source of bugs.

The page table dumpers seem to be using this to dump out the "name" of a
hole which seems a bit bogus in the first place.  I'd much rather teach
the dumpers about the length of the hole, "the hole is 0x12340000 bytes
long", rather than "there's a hole at this level".

Powered by blists - more mailing lists