linux-kernel - Re: [PATCH v3 20/34] sparc: mm: Add p?d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190227.103837.668255833945043179.davem@davemloft.net>
Date:   Wed, 27 Feb 2019 10:38:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     steven.price@....com
Cc:     linux-mm@...ck.org, luto@...nel.org, ard.biesheuvel@...aro.org,
        arnd@...db.de, bp@...en8.de, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, mingo@...hat.com, james.morse@....com,
        jglisse@...hat.com, peterz@...radead.org, tglx@...utronix.de,
        will.deacon@....com, x86@...nel.org, hpa@...or.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Mark.Rutland@....com, kan.liang@...ux.intel.com,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions

From: Steven Price <steven.price@....com>
Date: Wed, 27 Feb 2019 17:05:54 +0000

> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
> 
> For sparc, we don't support large pages, so add stubs returning 0.
> 
> CC: "David S. Miller" <davem@...emloft.net>
> CC: sparclinux@...r.kernel.org
> Signed-off-by: Steven Price <steven.price@....com>

Sparc does support large pages on 64-bit, just not at this level.  It
would be nice if the commit message was made more accurate.  Other than
that:

Acked-by: David S. Miller <davem@...emloft.net>