linux-kernel - Re: [PATCH v3 15/34] parisc: mm: Add p?d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa3072ba-f02b-fee5-dc16-d575a5308d4b@gmx.de>
Date:   Wed, 27 Feb 2019 19:54:22 +0100
From:   Helge Deller <deller@....de>
To:     Steven Price <steven.price@....com>, linux-mm@...ck.org
Cc:     Andy Lutomirski <luto@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>,
        James Morse <james.morse@....com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will.deacon@....com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Mark Rutland <Mark.Rutland@....com>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        linux-parisc@...r.kernel.org
Subject: Re: [PATCH v3 15/34] parisc: mm: Add p?d_large() definitions

On 27.02.19 18:05, Steven Price wrote:
> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
> 
> For parisc, we don't support large pages, so add stubs returning 0.

We do support huge pages on parisc, but not yet on those levels.
So, you may add

Acked-by: Helge Deller <deller@....de> # parisc
 
Helge

> CC: "James E.J. Bottomley" <jejb@...isc-linux.org>
> CC: Helge Deller <deller@....de>
> CC: linux-parisc@...r.kernel.org
> Signed-off-by: Steven Price <steven.price@....com>
> ---
>  arch/parisc/include/asm/pgtable.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/parisc/include/asm/pgtable.h b/arch/parisc/include/asm/pgtable.h
> index c7bb74e22436..1f38c85a9530 100644
> --- a/arch/parisc/include/asm/pgtable.h
> +++ b/arch/parisc/include/asm/pgtable.h
> @@ -302,6 +302,7 @@ extern unsigned long *empty_zero_page;
>  #endif
>  #define pmd_bad(x)	(!(pmd_flag(x) & PxD_FLAG_VALID))
>  #define pmd_present(x)	(pmd_flag(x) & PxD_FLAG_PRESENT)
> +#define pmd_large(x)	(0)
>  static inline void pmd_clear(pmd_t *pmd) {
>  #if CONFIG_PGTABLE_LEVELS == 3
>  	if (pmd_flag(*pmd) & PxD_FLAG_ATTACHED)
> @@ -324,6 +325,7 @@ static inline void pmd_clear(pmd_t *pmd) {
>  #define pgd_none(x)     (!pgd_val(x))
>  #define pgd_bad(x)      (!(pgd_flag(x) & PxD_FLAG_VALID))
>  #define pgd_present(x)  (pgd_flag(x) & PxD_FLAG_PRESENT)
> +#define pgd_large(x)	(0)
>  static inline void pgd_clear(pgd_t *pgd) {
>  #if CONFIG_PGTABLE_LEVELS == 3
>  	if(pgd_flag(*pgd) & PxD_FLAG_ATTACHED)
> @@ -342,6 +344,7 @@ static inline void pgd_clear(pgd_t *pgd) {
>  static inline int pgd_none(pgd_t pgd)		{ return 0; }
>  static inline int pgd_bad(pgd_t pgd)		{ return 0; }
>  static inline int pgd_present(pgd_t pgd)	{ return 1; }
> +static inline int pgd_large(pgd_t pgd)		{ return 0; }
>  static inline void pgd_clear(pgd_t * pgdp)	{ }
>  #endif
>  
>