lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 28 Feb 2019 14:42:13 -0600
From:   Bjorn Helgaas <>
To:     "Rafael J. Wysocki" <>
Cc:     Dongdong Liu <>,
        Lukas Wunner <>,
        Linux PCI <>,
        Linux PM <>,
        LKML <>
Subject: Re: [PATCH] PCI: PCIe: PME: Fix pcie_pme_remove()

On Wed, Feb 27, 2019 at 5:58 PM Rafael J. Wysocki <> wrote:
> From: Rafael J. Wysocki <>
> It is incorrect to call pcie_pme_suspend() from pcie_pme_remove() for
> two reasons.
> First, pcie_pme_suspend() calls synchronize_irq() that will wait for
> the native hotplug interrupt handler as well as for the PME one,
> because they share one IRQ (as per the spec).  That may deadlock if
> hotplug is signaled while pcie_pme_remove() is running and the latter
> calls pci_lock_rescan_remove() before the former.
> Second, if pcie_pme_suspend() figures out that wakeup needs to be
> enabled for the port, it will return without disabling the interrupt
> as expected by pcie_pme_remove() which was overlooked by commit
> c7b5a4e6e8fb ("PCI / PM: Fix native PME handling during system
> suspend/resume").
> To fix that, rework pcie_pme_remove() to disable the PME interrupt,
> clear its status and prevent the PME worker function from re-enabling it
> before calling free_irq() on it which should be sufficient.
> Fixes: c7b5a4e6e8fb ("PCI / PM: Fix native PME handling during system suspend/resume")
> Reported-by: Dongdong Liu <>
> Signed-off-by: Rafael J. Wysocki <>

I added the deadlock details from Dongdong and applied this to pci/pm
for v5.1, thanks!


Powered by blists - more mailing lists