linux-kernel - Re: [PATCH v3 20/34] sparc: mm: Add p?d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eee95a89-ed4a-dab9-1349-a50eee4f5b77@arm.com>
Date:   Thu, 28 Feb 2019 11:49:35 +0000
From:   Steven Price <steven.price@....com>
To:     David Miller <davem@...emloft.net>
Cc:     Mark.Rutland@....com, x86@...nel.org, arnd@...db.de,
        ard.biesheuvel@...aro.org, peterz@...radead.org,
        catalin.marinas@....com, dave.hansen@...ux.intel.com,
        will.deacon@....com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, jglisse@...hat.com, mingo@...hat.com,
        bp@...en8.de, luto@...nel.org, hpa@...or.com,
        sparclinux@...r.kernel.org, james.morse@....com,
        tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org,
        kan.liang@...ux.intel.com
Subject: Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions

On 27/02/2019 18:38, David Miller wrote:
> From: Steven Price <steven.price@....com>
> Date: Wed, 27 Feb 2019 17:05:54 +0000
> 
>> walk_page_range() is going to be allowed to walk page tables other than
>> those of user space. For this it needs to know when it has reached a
>> 'leaf' entry in the page tables. This information is provided by the
>> p?d_large() functions/macros.
>>
>> For sparc, we don't support large pages, so add stubs returning 0.
>>
>> CC: "David S. Miller" <davem@...emloft.net>
>> CC: sparclinux@...r.kernel.org
>> Signed-off-by: Steven Price <steven.price@....com>
> 
> Sparc does support large pages on 64-bit, just not at this level.  It
> would be nice if the commit message was made more accurate.  

Yes you are right, I fear I only looked at the 32 bit changes when I
wrote the commit message. I'll clarify the difference between 32/64 bit.

> Other than that:
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Thanks,

Steve