linux-kernel - Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqH_53Ued9vyBZDkpEzdFo=hRQs8J7QSQ-o7XRnDc2meb1GiQ@mail.gmail.com>
Date:   Thu, 28 Feb 2019 13:17:59 +0100
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Gwendal Grignou <gwendal@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Jett Rink <jettrink@...omium.org>,
        Guenter Roeck <groeck@...gle.com>,
        Rushikesh S Kadam <rushikesh.s.kadam@...el.com>,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Aaron Durbin <adurbin@...gle.com>,
        Duncan Laurie <dlaurie@...gle.com>
Subject: Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

Hi Andy,
Missatge de Andy Shevchenko <andriy.shevchenko@...el.com> del dia dj.,
28 de febr. 2019 a les 8:57:
>
> On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote:
> > Missatge de Gwendal Grignou <gwendal@...omium.org> del dia dc., 27 de
> > febr. 2019 a les 19:37:
> > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra
> > > <enric.balletbo@...labora.com> wrote:
> > > > On 27/2/19 16:13, Jett Rink wrote:
>
> > > You're right, the cros_ names are based on what the EC provides.
> > > cros_ec for generic EC, fp, tp for fingerprint, touch pad
> > > respectively.
> > > ish is for standalone sensor hub [it does not have to be Intel Sensor Hub].
> > >
> >
> > Thanks for the explanation. I didn't know that and I assumed the 'i'
> > was for 'intel', maybe would be good call cros_ssh or cros_sh to avoid
> > confusion?
>
> i is for Integrated. There is no confusion.

Ok, thanks for the clarification. Now that is clear to me I'll send
some reviews of this patch in a minute.

Best regards,
Enric

> It seems you misread what was written in [] above.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>