linux-kernel - Re: [PATCH] sched/cputime: Remove unnecessary assignment statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <397917cc-3656-e26c-7715-d4feec97bb4b@nvidia.com>
Date:   Thu, 28 Feb 2019 13:53:31 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Sachin Nikam <Snikam@...dia.com>
CC:     Ketan Patil <ketanp@...dia.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Bharat Nihalani <bnihalani@...dia.com>,
        Bo Yan <byan@...dia.com>,
        Sai Gurrappadi <sgurrappadi@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Timo Alho <talho@...dia.com>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement


On 28/02/2019 12:31, Peter Zijlstra wrote:
> 
> Clearly, because reading comprehension isn't your strong point:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?

Sorry we have a few people helping out cleaning up our kernel branches
and we need to do a better job here indeed!

> On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote:
> 
>> This isn't a security fix.
>> However, I see this is kind of code cleanup.
> 
> As I've explained previously, it makes conceptual sense to have it in
> the code, and any halfway sane compiler will observe the same double
> store and eliminate it in its DCE pass.

OK. Thanks for the feedback. We can agree to drop this and we will try
to do a better job reviewing this type of thing before hand in future.

Cheers
Jon

-- 
nvpublic