linux-kernel - Re: [PATCH] sched/cputime: Remove unnecessary assignment statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190228123120.GA32494@hirez.programming.kicks-ass.net>
Date:   Thu, 28 Feb 2019 13:31:20 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Sachin Nikam <Snikam@...dia.com>
Cc:     Ketan Patil <ketanp@...dia.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Bharat Nihalani <bnihalani@...dia.com>,
        Bo Yan <byan@...dia.com>,
        Sai Gurrappadi <sgurrappadi@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Timo Alho <talho@...dia.com>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement

Clearly, because reading comprehension isn't your strong point:

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote:

> This isn't a security fix.
> However, I see this is kind of code cleanup.

As I've explained previously, it makes conceptual sense to have it in
the code, and any halfway sane compiler will observe the same double
store and eliminate it in its DCE pass.