linux-kernel - RE: [PATCH] sched/cputime: Remove unnecessary assignment statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR12MB3278E52D04119DC55597A293BB750@MN2PR12MB3278.namprd12.prod.outlook.com>
Date:   Thu, 28 Feb 2019 12:14:09 +0000
From:   Sachin Nikam <Snikam@...dia.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        Ketan Patil <ketanp@...dia.com>
CC:     "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        Bharat Nihalani <bnihalani@...dia.com>,
        Bo Yan <byan@...dia.com>,
        Sai Gurrappadi <sgurrappadi@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        Timo Alho <talho@...dia.com>
Subject: RE: [PATCH] sched/cputime: Remove unnecessary assignment statement

Ketan,
What is the Coverity Impact Level for this defect?
If it is Low then we can whitelist this defect and change.

Peter,
This isn't a security fix.
However, I see this is kind of code cleanup.

-----Original Message-----
From: Peter Zijlstra <peterz@...radead.org> 
Sent: Thursday, February 28, 2019 3:18 PM
To: Ketan Patil <ketanp@...dia.com>
Cc: mingo@...hat.com; linux-kernel@...r.kernel.org; linux-tegra@...r.kernel.org; Sachin Nikam <Snikam@...dia.com>; Bharat Nihalani <bnihalani@...dia.com>; Bo Yan <byan@...dia.com>; Sai Gurrappadi <sgurrappadi@...dia.com>; Thierry Reding <treding@...dia.com>; Timo Alho <talho@...dia.com>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Thu, Feb 28, 2019 at 03:12:13PM +0530, Ketan Patil wrote:
> The coverity tool has detected this issue as an unused value, since 
> the code assigns the value to utime variable and then after the jump, 
> the value of utime again gets updated, hence the previous value is not 
> at all useful and this patch removes that first assignment.

Not a security issue then; just tell coverity to shut up.