linux-kernel - Re: [PATCH] sched/cputime: Remove unnecessary assignment statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190228094733.GY32494@hirez.programming.kicks-ass.net>
Date:   Thu, 28 Feb 2019 10:47:33 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Ketan Patil <ketanp@...dia.com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, snikam@...dia.com,
        bnihalani@...dia.com, byan@...dia.com, sgurrappadi@...dia.com,
        treding@...dia.com, talho@...dia.com
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Thu, Feb 28, 2019 at 03:12:13PM +0530, Ketan Patil wrote:
> The coverity tool has detected this issue as an unused value, since
> the code assigns the value to utime variable and then after the jump, the
> value of utime again gets updated, hence the previous value is not at all
> useful and this patch removes that first assignment.

Not a security issue then; just tell coverity to shut up.