linux-kernel - Re: + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190301065650.GA10954@avx2>
Date:   Fri, 1 Mar 2019 09:56:50 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        wang.bo116@....com.cn, WangBo <wdjjwb@....com>
Subject: Re: +
 include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm
 tree

On Fri, Mar 01, 2019 at 09:13:27AM +0900, Masahiro Yamada wrote:
> On Fri, Mar 1, 2019 at 7:08 AM Alexey Dobriyan <adobriyan@...il.com> wrote:
> >
> > On Thu, Feb 28, 2019 at 09:41:09AM -0800, akpm@...ux-foundation.org wrote:
> > > --- a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned
> > > +++ a/include/linux/types.h
> > > @@ -155,9 +155,9 @@ typedef u64 dma_addr_t;
> > >  typedef u32 dma_addr_t;
> > >  #endif
> > >
> > > -typedef unsigned __bitwise gfp_t;
> > > -typedef unsigned __bitwise slab_flags_t;
> > > -typedef unsigned __bitwise fmode_t;
> > > +typedef unsigned int __bitwise gfp_t;
> > > +typedef unsigned int __bitwise slab_flags_t;
> > > +typedef unsigned int __bitwise fmode_t;
> >
> > I don't know if this is desireable. Switching to "unsigned" is better:
> > 1 less token and less 80 column pressure.
> 
> 
> 
> See the following commit.

Ah, checkpatch.pl, how could we live without it.