linux-kernel - Re: + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQv4giq5r4AKv4Ff1KP7k7US2Sdt=m1ZAXsDmKWKhZ9vQ@mail.gmail.com>
Date:   Fri, 1 Mar 2019 09:13:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        wang.bo116@....com.cn, WangBo <wdjjwb@....com>
Subject: Re: + include-linux-typesh-use-unsigned-int-instead-of-unsigned.patch
 added to -mm tree

On Fri, Mar 1, 2019 at 7:08 AM Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> On Thu, Feb 28, 2019 at 09:41:09AM -0800, akpm@...ux-foundation.org wrote:
> > --- a/include/linux/types.h~include-linux-typesh-use-unsigned-int-instead-of-unsigned
> > +++ a/include/linux/types.h
> > @@ -155,9 +155,9 @@ typedef u64 dma_addr_t;
> >  typedef u32 dma_addr_t;
> >  #endif
> >
> > -typedef unsigned __bitwise gfp_t;
> > -typedef unsigned __bitwise slab_flags_t;
> > -typedef unsigned __bitwise fmode_t;
> > +typedef unsigned int __bitwise gfp_t;
> > +typedef unsigned int __bitwise slab_flags_t;
> > +typedef unsigned int __bitwise fmode_t;
>
> I don't know if this is desireable. Switching to "unsigned" is better:
> 1 less token and less 80 column pressure.



See the following commit.




commit a1ce18e4f941d2039aa3bdeee17db968919eac2f
Author: Joe Perches <joe@...ches.com>
Date:   Tue Mar 15 14:58:03 2016 -0700

    checkpatch: warn on bare unsigned or signed declarations without int

    Kernel style prefers "unsigned int <foo>" over "unsigned <foo>" and
    "signed int <foo>" over "signed <foo>".

    Emit a warning for these simple signed/unsigned <foo> declarations.  Fix
    it too if desired.

    Signed-off-by: Joe Perches <joe@...ches.com>
    Acked-by: David S. Miller <davem@...emloft.net>
    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>






-- 
Best Regards
Masahiro Yamada