linux-kernel - Re: [PATCH v5 0/3] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Mar 2019 11:55:43 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Maya Nakamura <m.maya.nakamura@...il.com>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org, kys@...rosoft.com,
        sthemmin@...rosoft.com, olaf@...fle.de, apw@...onical.com,
        jasowang@...hat.com, mikelley@...rosoft.com,
        Alexander.Levin@...rosoft.com, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, haiyangz@...rosoft.com,
        vkuznets@...hat.com, marcelo.cerri@...onical.com
Subject: Re: [PATCH v5 0/3] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset
 and cpumask_to_vpset()

On Fri, Mar 01, 2019 at 06:54:45AM +0000, Maya Nakamura wrote:
> This patchset removes a duplicate definition of VP set (hv_vp_set) and
> uses the common definition (hv_vpset) that is used in other places. It
> changes the order of the members in struct hv_pcibus_device due to
> flexible array in hv_vpset.
> 
> It also removes the duplicate implementation of cpumask_to_vpset(), uses
> the shared implementation, and exports hv_max_vp_index, which is
> required by cpumask_to_vpset().
> 
> It adds __aligned(8) to struct retarget_msi_interrupt because Hyper-V
> requires that hypercall arguments be aligned on an 8 byte boundary. This
> is now a new patch, separate from one of the previous patches.
> 
> Maya Nakamura (3):
>   PCI: hv: Add __aligned(8) to struct retarget_msi_interrupt
>   PCI: hv: Replace hv_vp_set with hv_vpset
>   PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()
> 
>  arch/x86/hyperv/hv_init.c           |  1 +
>  drivers/pci/controller/pci-hyperv.c | 61 +++++++++++++----------------
>  2 files changed, 29 insertions(+), 33 deletions(-)

It looks all good, applied to pci/hv for v5.1, pending kbot checks.

Thanks,
Lorenzo