lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Mar 2019 10:28:59 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Wen Yang <wen.yang99@....com.cn>, liviu.dudau@....com
Cc:     sudeep.holla@....com, lorenzo.pieralisi@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kgene@...nel.org, krzk@...nel.org,
        linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        dinguyen@...nel.org, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        linus.walleij@...aro.org, avifishman70@...il.com,
        tmaimon77@...il.com, venture@...gle.com, yuenn@...gle.com,
        brendanhiggins@...gle.com, openbmc@...ts.ozlabs.org,
        xuwei5@...ilicon.com, maxime.ripard@...tlin.com, wens@...e.org,
        catalin.marinas@....com, will.deacon@....com, horms@...ge.net.au,
        magnus.damm@...il.com, linux-renesas-soc@...r.kernel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        fabio.estevam@....com, linux-imx@....com, wang.yi59@....com.cn
Subject: Re: [PATCH 02/15] ARM: bcm: fix a leaked reference by addingmissing
 of_node_put

On 3/1/19 12:56 AM, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.

This looks fine, if you resubmit, can you add a missing space between
"adding" and "missing"? This applies to all of your patches, so I am
assuming you somehow scripted that, which should be easy to fix.

With that changed:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian

Powered by blists - more mailing lists