linux-kernel - Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by addingmissing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304053714.GZ26041@dragon>
Date:   Mon, 4 Mar 2019 13:37:15 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     liviu.dudau@....com, sudeep.holla@....com,
        lorenzo.pieralisi@....com, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kgene@...nel.org, krzk@...nel.org,
        linux-samsung-soc@...r.kernel.org, michal.simek@...inx.com,
        afaerber@...e.de, manivannan.sadhasivam@...aro.org,
        dinguyen@...nel.org, heiko@...ech.de,
        linux-rockchip@...ts.infradead.org, f.fainelli@...il.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linus.walleij@...aro.org,
        avifishman70@...il.com, tmaimon77@...il.com, venture@...gle.com,
        yuenn@...gle.com, brendanhiggins@...gle.com,
        openbmc@...ts.ozlabs.org, xuwei5@...ilicon.com,
        maxime.ripard@...tlin.com, wens@...e.org, catalin.marinas@....com,
        will.deacon@....com, horms@...ge.net.au, magnus.damm@...il.com,
        linux-renesas-soc@...r.kernel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, fabio.estevam@....com, linux-imx@....com,
        wang.yi59@....com.cn, Fabio Estevam <festevam@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by
 addingmissing of_node_put

On Fri, Mar 01, 2019 at 04:56:46PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>

Applied, thanks.