linux-kernel - Re: [PATCH] PCI: imx6: Don't request "pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1551468984.6059.10.camel@impinj.com>
Date:   Fri, 1 Mar 2019 19:36:25 +0000
From:   Trent Piepho <tpiepho@...inj.com>
To:     "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "cphealy@...il.com" <cphealy@...il.com>
Subject: Re: [PATCH] PCI: imx6: Don't request "pci_aux" clock on i.MX7

On Fri, 2019-03-01 at 00:55 -0800, Andrey Smirnov wrote:
> The clock in question is not present on i.MX7, so move the code
> requesting it into i.MX8MQ-only path.
> 
> Fixes: eeb61c4e8530 ("PCI: imx6: Add code to request/control
> "pcie_aux" clock for i.MX8MQ")
> Reported-by: Trent Piepho <tpiepho@...inj.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Chris Healy <cphealy@...il.com>
> Cc: Lucas Stach <l.stach@...gutronix.de>
> Cc: Trent Piepho <tpiepho@...inj.com>
> Cc: linux-imx@....com
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-pci@...r.kernel.org

Tested on linux-next, imx7d PCI-e appears to be working fine now.

It's too bad git diff can't report the case label(s) code falls under
the same way it can (usually) get the function name.  I saw the
original commit when it was posted and didn't notice anything myself
either.