linux-kernel - Re: [PATCH 11/15] habanalabs: print pointer using %p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Mar 2019 11:36:01 +0200
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/15] habanalabs: print pointer using %p

On Sat, Mar 2, 2019 at 3:00 AM Joe Perches <joe@...ches.com> wrote:
>
> On Thu, 2019-02-28 at 11:55 +0200, Oded Gabbay wrote:
> > Don't cast pointer to u64 to print it. Instead, print the pointer using
> > %p.
>
> You might want to use %px here if you _really_
> want the actual address and not the hashed output
> %p normally produces.
Yes, you are correct. Thanks for pointing it out, I'll fix that.
Oded


>
> > diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> []
> > @@ -4276,9 +4276,8 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
> >                       return 0;
> >
> >               dev_err(hdev->dev,
> > -                     "Internal CB address 0x%llx + 0x%x is not in SRAM nor in DRAM\n",
> > -                     (u64) (uintptr_t) parser->user_cb,
> > -                     parser->user_cb_size);
> > +                     "Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n",
> > +                     parser->user_cb, parser->user_cb_size);
>
>