linux-kernel - Re: [PATCH 11/15] habanalabs: print pointer using %p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b9cfc4a87bfd7a220f558f514e322f4864b13e.camel@perches.com>
Date:   Fri, 01 Mar 2019 17:00:20 -0800
From:   Joe Perches <joe@...ches.com>
To:     Oded Gabbay <oded.gabbay@...il.com>, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/15] habanalabs: print pointer using %p

On Thu, 2019-02-28 at 11:55 +0200, Oded Gabbay wrote:
> Don't cast pointer to u64 to print it. Instead, print the pointer using
> %p.

You might want to use %px here if you _really_
want the actual address and not the hashed output
%p normally produces.

> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
[]
> @@ -4276,9 +4276,8 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
>  			return 0;
>  
>  		dev_err(hdev->dev,
> -			"Internal CB address 0x%llx + 0x%x is not in SRAM nor in DRAM\n",
> -			(u64) (uintptr_t) parser->user_cb,
> -			parser->user_cb_size);
> +			"Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n",
> +			parser->user_cb, parser->user_cb_size);