linux-kernel - Re: [PATCH] x86/boot: clean up headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190302133010.135cd3ad@canb.auug.org.au>
Date:   Sat, 2 Mar 2019 13:30:10 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     bp@...en8.de, natechancellor@...il.com, niravd@...gle.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/boot: clean up headers

Hi Nick,

On Sat, 2 Mar 2019 13:27:50 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Fri,  1 Mar 2019 16:07:14 -0800 Nick Desaulniers <ndesaulniers@...gle.com> wrote:
> >
> > It turns out that arch/x86/boot/string.c doesn't actually need
> > linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them,
> > and sort the headers alphabetically.  
> 
> One small nit: please do not do the sort in the same commit as the bug
> fix.  It just complicates the review and has (a remote) possibility of
> adding a new problem.  (Not a big issue here, but in general cleanups
> and bug fixes should be separate.)

Also it is *very* common for headers to be included in the order:
linux/ asm/ and then local.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped