linux-kernel - Re: [PATCH] irqchip/imx-irqsteer: fix of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86d0n61gvn.wl-marc.zyngier@arm.com>
Date:   Mon, 04 Mar 2019 21:14:52 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Aisheng Dong <aisheng.dong@....com>,
        Fugang Duan <fugang.duan@....com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] irqchip/imx-irqsteer: fix of_property_read_u32() error handling

On Mon, 04 Mar 2019 20:02:18 +0000,
Arnd Bergmann <arnd@...db.de> wrote:
> 
> gcc points out that irqs_num is not initialized when of_property_read_u32()
> is an empty stub function:
> 
>                  Included from drivers/irqchip/irq-imx-irqsteer.c:7:
> drivers/irqchip/irq-imx-irqsteer.c: In function 'imx_irqsteer_probe':
> include/uapi/linux/kernel.h:13:49: error: 'irqs_num' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The same can actually happen with CONFIG_OF=y as well, though we don't
> get a warning then.
> 
> Add error checking here that lets the code deal with missing or
> invalid properties as well as avoid the warning.
> 
> Fixes: 28528fca4908 ("irqchip/imx-irqsteer: Add multi output interrupts support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/irqchip/irq-imx-irqsteer.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied, thanks Arnd.

	M.

-- 
Jazz is not dead, it just smell funny.