linux-kernel - Re: [PATCH] net: ignore sysctl_devconf_inherit_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190304.131459.349979845655858570.davem@davemloft.net>
Date:   Mon, 04 Mar 2019 13:14:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        Yanjun.Zhu@...driver.com, xiangxia.m.yue@...il.com,
        nicolas.dichtel@...nd.com, dsahern@...il.com, christian@...uner.io,
        lucien.xin@...il.com, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ignore sysctl_devconf_inherit_init_net without
 SYSCTL

From: Arnd Bergmann <arnd@...db.de>
Date: Mon,  4 Mar 2019 21:38:03 +0100

> When CONFIG_SYSCTL is turned off, we get a link failure for
> the newly introduced tuning knob.
> 
> net/ipv6/addrconf.o: In function `addrconf_init_net':
> addrconf.c:(.text+0x31dc): undefined reference to `sysctl_devconf_inherit_init_net'
> 
> Add an IS_ENABLED() check to fall back to the default behavior
> (sysctl_devconf_inherit_init_net=0) here.
> 
> Fixes: 856c395cfa63 ("net: introduce a knob to control whether to inherit devconf config")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.