linux-kernel - Re: A quesiton about commit 3a63f70bf4c3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190304012710.GB28322@localhost.localdomain>
Date:   Mon, 4 Mar 2019 09:27:10 +0800
From:   Chao Fan <fanc.fnst@...fujitsu.com>
To:     Baoquan He <bhe@...hat.com>
CC:     <bp@...en8.de>, <linux-kernel@...r.kernel.org>
Subject: Re: A quesiton about commit 3a63f70bf4c3

On Fri, Mar 01, 2019 at 02:06:31PM +0800, Baoquan He wrote:
>
>Hi Chao,
Hi Baoquan,

Sorry for late reply, I was away from keyboard last Friday.
Your change looks good, I think you can format it as a real PATCH.
>
>I am back porting this commit to our distrols from tip.

Thanks for your effort.

Thanks,
Chao Fan

>3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params
>
>Findind out those SRAT handling related declarations are out of
>BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose? 
>
>Saw "misc.h" is included in several places, shouldn't be changed like
>below? Please correct me if I was wrong.


>
>Thanks
>Baoquan
>
>diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
>index fd13655..252091b 100644
>--- a/arch/x86/boot/compressed/misc.h
>+++ b/arch/x86/boot/compressed/misc.h
>@@ -120,8 +120,6 @@ static inline void console_init(void)
> 
> void set_sev_encryption_mask(void);
> 
>-#endif
>-
> /* acpi.c */
> #ifdef CONFIG_ACPI
> acpi_physical_address get_rsdp_addr(void);
>@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
> #else
> static inline int count_immovable_mem_regions(void) { return 0; }
> #endif
>+#endif
>
>