linux-kernel - Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Mar 2019 09:27:11 +0800
From:   Chen Yu <chenyu56@...wei.com>
To:     John Stultz <john.stultz@...aro.org>
CC:     <liuyu712@...ilicon.com>,
        Linux USB List <linux-usb@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>,
        "Zhuangluan Su" <suzhuangluan@...ilicon.com>,
        Kongfei <kongfei@...ilicon.com>, <wanghu17@...ilicon.com>,
        <butao@...ilicon.com>, <chenyao11@...wei.com>,
        <fangshengzhou@...ilicon.com>,
        Li Pengcheng <lipengcheng8@...wei.com>,
        <songxiaowei@...ilicon.com>, YiPing Xu <xuyiping@...ilicon.com>,
        <xuyoujun4@...wei.com>, <yudongbin@...ilicon.com>,
        Zang Leigang <zangleigang@...ilicon.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        "Andy Shevchenko" <andy.shevchenko@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Binghui Wang <wangbinghui@...ilicon.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960



On 2019/3/4 4:17, John Stultz wrote:
> On Sat, Mar 2, 2019 at 4:05 AM Yu Chen <chenyu56@...wei.com> wrote:
>> +static int hisi_hikey_usb_probe(struct platform_device *pdev)
>> +{
>> +       struct device *dev = &pdev->dev;
>> +       struct device_node *root = dev->of_node;
> 
> Minor nit: root is unused and generates build warnings.
> 
OK. Thanks!

> thanks
> -john
> 
> .
> 

Thanks
Yu Chen