linux-kernel - RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7AB137701821F94BAF7B06C1747BA691011A3FE123@OS01.os.local>
Date:   Tue, 5 Mar 2019 16:35:04 +0000
From:   Ryan Pannell <ryan@...kl.com>
To:     Jagan Teki <jagan@...rulasolutions.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>
CC:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "linux-amarula@...rulasolutions.com" 
        <linux-amarula@...rulasolutions.com>
Subject: RE: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD
 initial support

We don't mind if it has to be:
compatible = "oceanic,5inmfd", "allwinner,sun50i-a64";

However, to avoid confusion, might it be worth including the part number (We list this as '5205 5" MFD') so this would become:
compatible = "oceanic,5205-5inmfd", "allwinner,sun50i-a64";

Perhaps this solves the issue. Please let me know thoughts.

Ryan Pannell
Development Team Lead
Oceanic Systems (UK) Ltd

-----Original Message-----
From: Jagan Teki <jagan@...rulasolutions.com> 
Sent: 05 March 2019 16:08
To: Maxime Ripard <maxime.ripard@...tlin.com>
Cc: Chen-Yu Tsai <wens@...e.org>; Rob Herring <robh+dt@...nel.org>; Mark Rutland <mark.rutland@....com>; Ryan Pannell <ryan@...kl.com>; Michael Trimarchi <michael@...rulasolutions.com>; linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>; devicetree <devicetree@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>; linux-amarula@...rulasolutions.com
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: Add Oceanic A64-5inMFD initial support

On Tue, Mar 5, 2019 at 9:29 PM Maxime Ripard <maxime.ripard@...tlin.com> wrote:
>
> On Fri, Mar 01, 2019 at 10:27:14PM +0530, Jagan Teki wrote:
> > On Fri, Mar 1, 2019 at 8:27 PM Maxime Ripard <maxime.ripard@...tlin.com> wrote:
> > >
> > > On Wed, Feb 27, 2019 at 09:49:23PM +0530, Jagan Teki wrote:
> > > > On Wed, Feb 27, 2019 at 9:03 PM Maxime Ripard <maxime.ripard@...tlin.com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Tue, Feb 26, 2019 at 11:32:40AM +0530, Jagan Teki wrote:
> > > > > > Oceanic A64-5inMFD is a 5 inch Multi function display 
> > > > > > baseboard designed to mount SoPine SOM.
> > > > > >
> > > > > > Key features:
> > > > > > - Allwinner A64 Cortex-A53
> > > > > > - Mali-400MP2 GPU
> > > > > > - AXP803 PMIC
> > > > > > - 2GB DDR3 RAM
> > > > > > - SD Slot
> > > > > > - SPI-NOR flash
> > > > > > - EMAC, RTL8211E
> > > > > > - MCP2515 CAN
> > > > > > - MIPI-DSI
> > > > > > - Goodix 911 CTP
> > > > > > - USB Host
> > > > > > - 12V DC power supply
> > > > > >
> > > > > > Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
> > > > > > ---
> > > > > >  arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> > > > > >  .../allwinner/sun50i-a64-oceanic-5inmfd.dts   | 46 +++++++++++++++++++
> > > > > >  2 files changed, 47 insertions(+)  create mode 100644 
> > > > > > arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dts
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile 
> > > > > > b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > index a5fb1eaa8acf..ec39fe856117 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > > > > @@ -2,6 +2,7 @@
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-amarula-relic.dtb
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-bananapi-m64.dtb 
> > > > > > sun50i-a64-bananapi-m64-icn6211.dtb
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-nanopi-a64.dtb
> > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-oceanic-5inmfd.dtb
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino.dtb
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
> > > > > >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb diff 
> > > > > > --git 
> > > > > > a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt
> > > > > > s 
> > > > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmfd.dt
> > > > > > s
> > > > > > new file mode 100644
> > > > > > index 000000000000..d73d1f55acb9
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5inmf
> > > > > > +++ d.dts
> > > > > > @@ -0,0 +1,46 @@
> > > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > > +/*
> > > > > > + * Copyright (C) 2019 Oceanic Systems (UK) Ltd.
> > > > > > + * Copyright (C) 2019 Amarula Solutions B.V.
> > > > > > + * Author: Jagan Teki <jagan@...rulasolutions.com>  */
> > > > > > +
> > > > > > +/dts-v1/;
> > > > > > +
> > > > > > +#include "sun50i-a64-sopine.dtsi"
> > > > > > +
> > > > > > +/ {
> > > > > > +     model = "Oceanic A64-5inMFD";
> > > > > > +     compatible = "oceanic,a64-5inmfd", 
> > > > > > +"allwinner,sun50i-a64";
> > > > >
> > > > > The name of the DT is Oceanic 5inMFD, while you call the board 
> > > > > A64-5inMFD here, which name is the actual name?
> > > >
> > > > Yes, this is something that we discussed during "Amarula A64-Relic"
> > > > naming convention.
> > > >
> > > > Since these boards are not famous like teres-i we agreed to add 
> > > > vendor name after sun50i-a64- followed by real board name.
> > > >
> > > > Here A64 already covered during sun50i-a64- so the dts name 
> > > > simply the <vendor_name>-<real_board_name>
> > >
> > > For the DT name, yeah, we want that pattern.
> > >
> > > For the compatible and model, we want to use the model name.
> >
> > Entire model name after <vendor_name>, ?
> >
> > model = "Oceanic A64-5inMFD";
> > compatible = "oceanic,a64-5inmfd", "allwinner,sun50i-a64";
> >
> > is this not sufficient?
> >
> > Let me understand with respective few existing stuff.
> >
> > model = "Amarula A64-Relic";
> > compatible = "amarula,a64-relic", "allwinner,sun50i-a64";
> >
> > model = "Olimex A64 Teres-I"
> > compatible = "olimex,a64-teres-i", "allwinner,sun50i-a64";
>
> This one is called the TERES-A64:
> https://www.olimex.com/Products/DIY-Laptop/KITS/TERES-A64-WHITE/open-s
> ource-hardware
>
> The laptop is the Teres-I, it can have an A64
>
> > model = "FriendlyARM NanoPi A64";
> > compatible = "friendlyarm,nanopi-a64", "allwinner,sun50i-a64";
>
> NanoPi A64 is the name of the board: http://nanopi.io/nanopi-a64.html
>
> > model = "Olimex A64-Olinuxino";
> > compatible = "olimex,a64-olinuxino", "allwinner,sun50i-a64"
>
> A64-Olinuxino is the name of the board too:
> https://www.olimex.com/Products/OLinuXino/A64/A64-OLinuXino/open-sourc
> e-hardware
>
> > Would you comment, what is the different with respect to my change?
>
> If the name of the product is 5inMFD, then the model should be Oceanic 
> 5inMFD, and its compatible oceanic,5inmfd

Oceanic seems to have some multiple Multi Function Devices, ie reason we prefer the product as 'A64-5inMFD' since it is A64 based. In this case the model and compatible should be fine I think?